Bug 37401 - WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
Summary: WinEWS bot fails to svn update because scm.clean_working_directory leaves fil...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-10 20:56 PDT by Eric Seidel (no email)
Modified: 2010-04-10 22:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.63 KB, patch)
2010-04-10 21:08 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-10 20:56:30 PDT
WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
Comment 1 Eric Seidel (no email) 2010-04-10 21:08:09 PDT
Created attachment 53070 [details]
Patch
Comment 2 WebKit Review Bot 2010-04-10 21:12:19 PDT
Attachment 53070 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:179:  deprecated form of raising exception  [pep8/W602] [5]
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:188:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2010-04-10 21:16:05 PDT
Comment on attachment 53070 [details]
Patch

YYYYYYYAAAAAAAAAAYYYYYYYY
Comment 4 WebKit Commit Bot 2010-04-10 22:27:18 PDT
Comment on attachment 53070 [details]
Patch

Clearing flags on attachment: 53070

Committed r57439: <http://trac.webkit.org/changeset/57439>
Comment 5 WebKit Commit Bot 2010-04-10 22:27:23 PDT
All reviewed patches have been landed.  Closing bug.