Bug 37385 – [Haiku] Use all the new system cursors in CursorHaiku.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Stephan Aßmus]

I've recently added all sorts of system cursors for Haiku, this patch adds support for them in the WebKit port. The definitions for PlatformCursor and PlatformCursorHandle had to be changed for convenience in other parts of the port.

[Stephan Aßmus]

Created attachment 53037 [details]
[Haiku] Use all the new system cursors

[Eric Seidel (no email)]

Comment on attachment 53037 [details]
[Haiku] Use all the new system cursors

Seems either a helper function, or adding some new constructor to Cursor would be cleaner than " Cursor(BCursor(" every time.

[Stephan Aßmus]

Created attachment 53097 [details]
[Haiku] Use all the new system cursors

Revised patch with helper function to create Cursors from BCursorIDs.

[David Levin]

Comment on attachment 53097 [details]
[Haiku] Use all the new system cursors

> Index: WebCore/ChangeLog
> [phone]  Stephan AÃmus  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Haiku] Use all the new system cursors available in recent Haiku revisions.
> +        <https://bugs.webkit.org/show_bug.cgi?id=37385>
> +
> +        Covered by existing tests.
> +
> +        * platform/Cursor.h:
> +            - Added necessary include.
> +            - Changed definitions of PlatformCursor and PlatformCursorHandle.

It is clear that you did this but why you did it is unclear. This results in an ifdef in Cursor.h (to change the return type of impl()) where all other ports have been able to avoid it.

r- due to new ifdef which changes the return type of impl().

[Stephan Aßmus]

Created attachment 53232 [details]
[Haiku] Use all the new system cursors

Revised patch, Cursor now keeps a pointer to a BCursor again. Cursor.h needs to changes at all anymore. Also fixed the coding style on the names for static variables, somehow I was under the impression I read this in the style guide document, but I was mistaken.

[WebKit Commit Bot]

Comment on attachment 53232 [details]
[Haiku] Use all the new system cursors

Clearing flags on attachment: 53232

Committed r57512: <http://trac.webkit.org/changeset/57512>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.