Bug 37380 - new-run-webkit-tests should store results to a directory under the build tree
Summary: new-run-webkit-tests should store results to a directory under the build tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 21:39 PDT by Dirk Pranke
Modified: 2010-04-10 23:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2010-04-10 22:52 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-09 21:39:39 PDT
Currently, new-run-webkit-tests stores results in /tmp/run-chromium-webkit-tests-layout-test-results/* (run-chromium-webkit-tests being a short-lived name for the script). It would probably be better if the script stored results under the build directories somewhere to avoid collisions between multiple checkouts on the same machine.
Comment 1 Eric Seidel (no email) 2010-04-10 22:52:58 PDT
Created attachment 53075 [details]
Patch
Comment 2 Adam Barth 2010-04-10 22:54:30 PDT
Comment on attachment 53075 [details]
Patch

Are you sure nothing downstream depends on the name?
Comment 3 Eric Seidel (no email) 2010-04-10 22:55:59 PDT
Comment on attachment 53075 [details]
Patch

This is a per-port setting.   Chromium stores things somewhere else.
Comment 4 WebKit Commit Bot 2010-04-10 23:05:38 PDT
Comment on attachment 53075 [details]
Patch

Clearing flags on attachment: 53075

Committed r57442: <http://trac.webkit.org/changeset/57442>
Comment 5 WebKit Commit Bot 2010-04-10 23:05:43 PDT
All reviewed patches have been landed.  Closing bug.