Bug 37376 - new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
Summary: new-run-webkit-tests --release fails to build release DRT when global configu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 17:42 PDT by Adam Barth
Modified: 2010-04-09 19:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2010-04-09 17:42 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-09 17:42:14 PDT
new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
Comment 1 Adam Barth 2010-04-09 17:42:55 PDT
Created attachment 53023 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-09 18:21:07 PDT
Comment on attachment 53023 [details]
Patch

OK.  Seems we should have the flag lookup in some central config location.  The whole configuration nonsense should be shared in some central common file.
Comment 3 Adam Barth 2010-04-09 19:16:08 PDT
Yeah.  We must have that code in webkitpy somewhere already.
Comment 4 Adam Barth 2010-04-09 19:17:16 PDT
Comment on attachment 53023 [details]
Patch

Clearing flags on attachment: 53023

Committed r57398: <http://trac.webkit.org/changeset/57398>
Comment 5 Adam Barth 2010-04-09 19:17:23 PDT
All reviewed patches have been landed.  Closing bug.