Bug 37368 - Add MiniBrowser for new WebKit API
Summary: Add MiniBrowser for new WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 15:33 PDT by Sam Weinig
Modified: 2010-04-09 15:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (305.71 KB, patch)
2010-04-09 15:33 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-04-09 15:33:34 PDT
Created attachment 53002 [details]
Patch

Add MiniBrowser for new WebKit API.
Comment 1 Anders Carlsson 2010-04-09 15:35:30 PDT
Comment on attachment 53002 [details]
Patch

r=me
Comment 2 WebKit Review Bot 2010-04-09 15:36:05 PDT
Attachment 53002 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit2/MiniBrowser/win/main.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/main.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/MiniBrowser/mac/BrowserWindowController.h:36:  _pageNamespace is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/MiniBrowser/win/MiniBrowser.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/MiniBrowser.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/resource.h:1:  Should have a space between // and comment  [whitespace/comments] [4]
WebKit2/MiniBrowser/win/stdafx.cpp:30:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserView.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserView.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserWindow.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserWindow.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 11 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-04-09 15:46:02 PDT
Actually, could you put MiniBrowser in WebKitTools instead? Thanks!
Comment 4 Sam Weinig 2010-04-09 15:48:58 PDT
Landed in r57374.