Bug 37367 - Make Generated V8 code adhere to webkit style
Summary: Make Generated V8 code adhere to webkit style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 15:29 PDT by Yaar Schnitman
Modified: 2010-04-20 20:53 PDT (History)
4 users (show)

See Also:

Attachments
patch (50.57 KB, patch)
2010-04-20 15:58 PDT, Nate Chapin 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2010-04-09 15:29:56 PDT 
I almost adheres, but there are a few things it doesn't.
Comment 1 Nate Chapin 2010-04-20 15:58:32 PDT 
Created attachment 53901 [details]
patch

This also fixes a bunch of style violations the TestObj.idl doesn't trigger.  I ran check-webkit-style over the entire generated bindings, and there now is only a single violation (in V8DOMWindow.cpp), which would be non-trivial to resolve and probably cause the script to become substantially less readable.
Comment 2 Dimitri Glazkov (Google) 2010-04-20 16:05:54 PDT 
Comment on attachment 53901 [details]
patch

awesome. Thanks!
Comment 3 Nate Chapin 2010-04-20 16:29:07 PDT 
http://trac.webkit.org/changeset/57936