Bug 37349 – [RenderStyle Cleanup] Clean up BorderValue, CollapsedBorderValue, BorderData and OutlineValue

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

Make them all have the same style (classes with m_ members and accessors for those members).  Let RenderStyle poke the members directly for setting.

[Dave Hyatt]

Created attachment 52981 [details]
Patch

[WebKit Review Bot]

Attachment 52981 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/style/BorderValue.h:44:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/style/BorderValue.h:49:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/style/BorderData.h:86:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 52981 [details]
Patch

>  class BorderData {
> +friend class RenderStyle;

I think we normally put friend declarations at the start of "private:" sections. But maybe that's not as common as I think? (Same goes for BorderValue and CollapsedBorderValue.)

> +    Color color() const { return m_borderColor; }

Could make this return a const Color& while you're at it.

r=me

[Dave Hyatt]

Fixed in r57355.

[WebKit Review Bot]

http://trac.webkit.org/changeset/57355 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/57355
http://trac.webkit.org/changeset/57356

[Adam Barth]

Looks like our flaky XMLHttpRequest woes on Snow Leopard aren't over:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r57358%20(8003)/http/tests/xmlhttprequest/basic-auth-pretty-diff.html