RESOLVED FIXED 37347
Don't use CF types in the new C API 
https://bugs.webkit.org/show_bug.cgi?id=37347
Summary Don't use CF types in the new C API
Sam Weinig
Reported 2010-04-09 11:39:44 PDT
Created attachment 52971 [details] Patch Use WK types instead.
Attachments
Patch (58.39 KB, patch)
2010-04-09 11:39 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-04-09 11:42:11 PDT
Comment on attachment 52971 [details] Patch > + WebCore::KURL& url() { return m_url; } This should be const. Looks good otherwise. r=me
Geoffrey Garen
Comment 2 2010-04-09 13:03:29 PDT
The KURLWrapper::create boilerplate here is unfortunate. It would be better if KURL itself were refcounted, like StringImpl. That would avoid an allocation at the API boundary, too. Same goes for ResourceRequest, ResourceResponse, etc.
Brady Eidson
Comment 3 2010-04-09 14:13:58 PDT
(In reply to comment #2) > The KURLWrapper::create boilerplate here is unfortunate. It would be better if > KURL itself were refcounted, like StringImpl. That would avoid an allocation at > the API boundary, too. > > Same goes for ResourceRequest, ResourceResponse, etc. Indeed, it would be good for WebCore as a cross-platform whole if that were the case.
Sam Weinig
Comment 4 2010-04-09 15:48:07 PDT
Fixed in r57352.
Note You need to log in before you can comment on or make changes to this bug.