Bug 37347 - Don't use CF types in the new C API
Summary: Don't use CF types in the new C API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 11:39 PDT by Sam Weinig
Modified: 2010-04-09 15:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (58.39 KB, patch)
2010-04-09 11:39 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-04-09 11:39:44 PDT
Created attachment 52971 [details]
Patch

Use WK types instead.
Comment 1 Anders Carlsson 2010-04-09 11:42:11 PDT
Comment on attachment 52971 [details]
Patch


> +    WebCore::KURL& url() { return m_url; }

This should be const. Looks good otherwise.

r=me
Comment 2 Geoffrey Garen 2010-04-09 13:03:29 PDT
The KURLWrapper::create boilerplate here is unfortunate. It would be better if KURL itself were refcounted, like StringImpl. That would avoid an allocation at the API boundary, too.

Same goes for ResourceRequest, ResourceResponse, etc.
Comment 3 Brady Eidson 2010-04-09 14:13:58 PDT
(In reply to comment #2)
> The KURLWrapper::create boilerplate here is unfortunate. It would be better if
> KURL itself were refcounted, like StringImpl. That would avoid an allocation at
> the API boundary, too.
> 
> Same goes for ResourceRequest, ResourceResponse, etc.

Indeed, it would be good for WebCore as a cross-platform whole if that were the case.
Comment 4 Sam Weinig 2010-04-09 15:48:07 PDT
Fixed in r57352.