PASS : tst_QWebFrame::initTestCase()
FAIL! : tst_QWebFrame::popupFocus() 'combo != 0' returned FALSE. ()
PASS : tst_QWebFrame::cleanupTestCase()
Reproducible on Linux/X11. It does not appear to be timing related, it fails consistenly for me.
Created attachment 52972 [details]
The class WebCore::QWebPopup has been removed, so the test cases need to be updated also.
I can verify that this is the right fix. But you should elaborate more on what you are doing and how you fixed it in change log.
(In reply to comment #2)
> I can verify that this is the right fix. But you should elaborate more on what
> you are doing and how you fixed it in change log.
I agree, the ChangeLog entry doesn't fulfill the requirements of the projects, r- for that reason. Please provide a new patch with a better description and I will review it ASAP! Thanks :-)
Created attachment 52980 [details]
updated the description in the changelog
Comment on attachment 52980 [details]
> + The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.
:-( Please keep the changelog at max 80-100 char per line as everyone else. sorry
Created attachment 52982 [details]
It's my bad :) Thanks for the reviewing.
Comment on attachment 52982 [details]
Clearing flags on attachment: 52982
Committed r57388: <http://trac.webkit.org/changeset/57388>
All reviewed patches have been landed. Closing bug.
Revision r57388 cherry-picked into qtwebkit-2.0 with commit 862268aeb7150d3795d05bfc05f661bb5c598a27