Bug 37315 - DumpRenderTree should log pushState/replaceState changing URL in the address bar
Summary: DumpRenderTree should log pushState/replaceState changing URL in the address bar
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 02:04 PDT by Jonas Beck
Modified: 2010-12-02 22:33 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Beck 2010-04-09 02:04:05 PDT
This is maybe not a bug, but the specs indicates that the documents URL should change when pushState is called and it seems strange to not reflect this in the UI as well.

"The document's address is an absolute URL  that is set when the Document is created. The document's current address is an absolute URL  that can change during the lifetime of the Document, for example when the user navigates to a fragment identifier on the page or when the pushState() method is called with a new URL." http://www.whatwg.org/specs/web-apps/current-work/#documents

Both Minefield and Chromium change the URL in the address bar when pushState is used. 

A important use case for this feature would be if content is loaded with ajax and the user would like to use the URL in the address for tipping about this specific content.
Comment 1 Brady Eidson 2010-04-09 10:46:34 PDT
Chrome and Minefield have the advantage of having released a new browser client in addition to their engine changes that implement replaceState.

WebKit implements the callback for client apps in WebFrameLoaderClient.mm:
void WebFrameLoaderClient::dispatchDidReplaceStateWithinPage()

But currently shipping Safari doesn't listen for it for obvious reasons. (it doesn't ship with a WebKit that supports the feature)

This bugzilla is still interesting, however, because DRT should listen for both the push and replace state callbacks and dump them out, so we can at least have layouttest coverage.
Comment 2 Erik Arvidsson 2010-04-23 10:42:42 PDT
Chrome does not yet update the address bar:

http://code.google.com/p/chromium/issues/detail?id=36548
Comment 3 Mihai Parparita 2010-12-02 15:37:45 PST
Should this bug still be open? Both Chrome and Safari now update the location bar.
Comment 4 Alexey Proskuryakov 2010-12-02 22:33:43 PST
The original report is not about anything in open source WebKit. But Brady suggested repurposing it for DumpRenderTree improvement, which makes sense to me.