37294 – WebView::isLoading should null check m_mainFrame

RESOLVED FIXED 37294

WebView::isLoading should null check m_mainFrame

https://bugs.webkit.org/show_bug.cgi?id=37294

Summary WebView::isLoading should null check m_mainFrame

Steve Falkenburg

Reported 2010-04-08 15:35:28 PDT

WebView::isLoading should null check m_mainFrame

Attachments
Patch (975 bytes, patch) 2010-04-08 15:46 PDT, Steve Falkenburg	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Falkenburg

Comment 1 2010-04-08 15:46:35 PDT

Created attachment 52904 [details] Patch

Darin Adler

Comment 2 2010-04-08 15:56:04 PDT

Comment on attachment 52904 [details] Patch Can this just return FALSE without failing, though? Why is it a failure to ask this question of a WebView without a main frame?

Steve Falkenburg

Comment 3 2010-04-08 16:01:15 PDT

http://trac.webkit.org/changeset/57302

WebKit Review Bot

Comment 4 2010-04-08 17:13:07 PDT

http://trac.webkit.org/changeset/57302 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57304 http://trac.webkit.org/changeset/57301 http://trac.webkit.org/changeset/57302 http://trac.webkit.org/changeset/57303

Adam Barth

Comment 5 2010-04-08 17:21:12 PDT

Sorry for the sheriffbot spam. We're fighting through storage/open-database-creation-callback.html.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Other

OS OS X 10.5

Product WebKit

Component New Bugs

Assignee

Steve Falkenburg

Reported

2010-04-08 15:35 PDT

Modified

2010-04-08 17:21 PDT History

CC List

3 users Show

URL

Keywords

Depends on

Blocks