Bug 37294 - WebView::isLoading should null check m_mainFrame
Summary: WebView::isLoading should null check m_mainFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 15:35 PDT by Steve Falkenburg
Modified: 2010-04-08 17:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (975 bytes, patch)
2010-04-08 15:46 PDT, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-04-08 15:35:28 PDT
WebView::isLoading should null check m_mainFrame
Comment 1 Steve Falkenburg 2010-04-08 15:46:35 PDT
Created attachment 52904 [details]
Patch
Comment 2 Darin Adler 2010-04-08 15:56:04 PDT
Comment on attachment 52904 [details]
Patch

Can this just return FALSE without failing, though? Why is it a failure to ask this question of a WebView without a main frame?
Comment 3 Steve Falkenburg 2010-04-08 16:01:15 PDT
http://trac.webkit.org/changeset/57302
Comment 5 Adam Barth 2010-04-08 17:21:12 PDT
Sorry for the sheriffbot spam.  We're fighting through storage/open-database-creation-callback.html.