Bug 37290 - REGRESSION (r55823): database callbacks happen in an isolated world
Summary: REGRESSION (r55823): database callbacks happen in an isolated world
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dumitru Daniliuc
Depends on:
Reported: 2010-04-08 14:02 PDT by Geoffrey Garen
Modified: 2010-04-09 00:36 PDT (History)
4 users (show)

See Also:

patch (1.32 KB, patch)
2010-04-08 15:09 PDT, Dumitru Daniliuc
abarth: review-
dumi: commit-queue-
Details | Formatted Diff | Diff
patch (4.40 KB, patch)
2010-04-08 15:23 PDT, Dumitru Daniliuc
ggaren: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2010-04-08 14:02:05 PDT
http://trac.webkit.org/changeset/55823 changed database callbacks in JSC, creating a new isolated world for each callback. This seems clearly wrong. A callback should just reuse the world it was created with.

    , m_isolatedWorld(DOMWrapperWorld::create(globalObject->globalData(), true))
should be this:
    , m_isolatedWorld(globalObject->world())
Comment 1 Dumitru Daniliuc 2010-04-08 14:25:20 PDT
On it.
Comment 2 Dumitru Daniliuc 2010-04-08 15:09:03 PDT
Created attachment 52899 [details]
Comment 3 Adam Barth 2010-04-08 15:13:19 PDT
Comment on attachment 52899 [details]

Test?  Or does this fix the open-database test that's failing?
Comment 4 Geoffrey Garen 2010-04-08 15:19:34 PDT
No, it needs a new test.
Comment 5 Adam Barth 2010-04-08 15:20:20 PDT
Comment on attachment 52899 [details]

You heard the man.
Comment 6 Dumitru Daniliuc 2010-04-08 15:23:48 PDT
Created attachment 52901 [details]

(In reply to comment #5)
> (From update of attachment 52899 [details])
> You heard the man.

Comment 7 Geoffrey Garen 2010-04-08 15:27:24 PDT
Comment on attachment 52901 [details]

Comment 8 Dumitru Daniliuc 2010-04-08 15:55:47 PDT
Landed as r57301.
Comment 10 Dumitru Daniliuc 2010-04-08 17:15:20 PDT
(In reply to comment #9)
> http://trac.webkit.org/changeset/57301 might have broken Tiger Intel Release
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/57304
> http://trac.webkit.org/changeset/57301
> http://trac.webkit.org/changeset/57302
> http://trac.webkit.org/changeset/57303

None of these changes are to blame. The bots just happened to like open-database-creation-callback-isolated-world.html in the previous run, but it failed again when these 4 patches were pulled in.
Comment 11 Eric Seidel (no email) 2010-04-09 00:36:26 PDT
The bots have been failing for 12 hours, ever since bug 31482 went in.  As far as I can tell, this depends on bug 31482, so I think I'll need to roll both out since Dumi is not around.