Testing utility for CodeGeneratorV8.pm
Created attachment 52882 [details] Patch
The auto-generated files fail the style checks, and they should.
Attachment 52882 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Last 3072 characters of output: [3] WebCore/bindings/v8/test/V8TestObj.cpp:379: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/v8/test/V8TestObj.cpp:380: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/v8/test/V8TestObj.cpp:381: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/v8/test/V8TestObj.cpp:385: default_signature is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:386: Missing spaces around / [whitespace/operators] [3] WebCore/bindings/v8/test/V8TestObj.cpp:387: Missing spaces around / [whitespace/operators] [3] WebCore/bindings/v8/test/V8TestObj.cpp:393: voidMethodWithArgs_argc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:394: voidMethodWithArgs_argv is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:395: voidMethodWithArgs_signature is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:399: intMethodWithArgs_argc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:400: intMethodWithArgs_argv is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:401: intMethodWithArgs_signature is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:405: objMethodWithArgs_argc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:406: objMethodWithArgs_argv is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:407: objMethodWithArgs_signature is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:417: V8TestObj_raw_cache_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.cpp:423: V8TestObj_cache_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bindings/v8/test/V8TestObj.h:21: #ifndef header guard has wrong style, please use: V8TestObj_h [build/header_guard] [5] WebCore/bindings/v8/test/V8TestObj.h:26: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/test/V8TestObj.h:28: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/test/V8TestObj.h:49: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 56 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 52882 [details] Patch If you could open a bug for getting the output of CodeGeneratorV8.pm more style compliant, that would be great (or we could attach it to this bug I suppose). > diff --git a/WebCore/bindings/v8/test/TestObj.idl b/WebCore/bindings/v8/test/TestObj.idl > new file mode 100644 > index 0000000..628b618 > --- /dev/null > +++ b/WebCore/bindings/v8/test/TestObj.idl > @@ -0,0 +1,65 @@ > +/* > + * Copyright (C) 2009 Google Inc. All rights reserved. 2010 :)
Committed r57378: <http://trac.webkit.org/changeset/57378>
Comment on attachment 52882 [details] Patch Should we hook this up to test-webkitpy to it get run from time to time?
I bet the jsc peeps would like to see this. :)