Bug 37266 - [Qt] Warnings when compiling InspectorClientQt.cpp
Summary: [Qt] Warnings when compiling InspectorClientQt.cpp
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Enhancement
Assignee: Benjamin Poulain
URL:
Keywords: Qt
Depends on:
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-04-08 06:32 PDT by Benjamin Poulain
Modified: 2010-04-09 01:15 PDT (History)
2 users (show)

See Also:


Attachments
Simple patch (1.12 KB, patch)
2010-04-08 06:38 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-04-08 06:32:21 PDT
When compiling InspectorClientQt.cpp, GCC output tons of warning for the switch():

WebCoreSupport/InspectorClientQt.cpp: In function 'WebCore::InspectorController::Setting WebCore::variantToSetting(const QVariant&)':                                              
WebCoreSupport/InspectorClientQt.cpp:213: warning: enumeration value 'Invalid' not handled in switch                                                                               
WebCoreSupport/InspectorClientQt.cpp:213: warning: enumeration value 'UInt' not handled in switch                                                                                  
WebCoreSupport/InspectorClientQt.cpp:213: warning: enumeration value 'LongLong' not handled in switch    
etc, etc
Comment 1 Benjamin Poulain 2010-04-08 06:38:57 PDT
Created attachment 52858 [details]
Simple patch
Comment 2 WebKit Commit Bot 2010-04-08 08:57:20 PDT
Comment on attachment 52858 [details]
Simple patch

Clearing flags on attachment: 52858

Committed r57281: <http://trac.webkit.org/changeset/57281>
Comment 3 WebKit Commit Bot 2010-04-08 08:57:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2010-04-09 01:15:11 PDT
Revision r57281 cherry-picked into qtwebkit-2.0 with commit 495f0dbc739bad809f60326825424758b7daf526