Bug 37265 - IDB callbacks should fire asynchronously
Summary: IDB callbacks should fire asynchronously
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
Depends on:
Reported: 2010-04-08 06:24 PDT by Jeremy Orlow
Modified: 2010-04-08 07:56 PDT (History)
9 users (show)

See Also:

Patch (4.81 KB, patch)
2010-04-08 06:37 PDT, Jeremy Orlow
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-04-08 06:24:41 PDT
IDB callbacks should fire asynchronously
Comment 1 Jeremy Orlow 2010-04-08 06:37:57 PDT
Created attachment 52856 [details]
Comment 2 Jeremy Orlow 2010-04-08 06:39:44 PDT
In addition to being the right thing to do, this exposes the bug we've been working on in --single-process mode within Chromium.
Comment 3 Eric Seidel (no email) 2010-04-08 06:40:05 PDT
Attachment 52856 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1674139
Comment 4 Early Warning System Bot 2010-04-08 06:45:48 PDT
Attachment 52856 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1660252
Comment 5 WebKit Review Bot 2010-04-08 06:48:48 PDT
Attachment 52856 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1612322
Comment 6 Jeremy Orlow 2010-04-08 06:49:05 PDT
Oops...will upload a new version that doesn't break everything in a sec.

Pavel/Yury: Note that this patch also makes the inspector bug I was seeing show up in single process mode.  Still don't know if the bug is related to my code (or why it's not working correctly) or whether it's a bug in inspector.
Comment 7 Yury Semikhatsky 2010-04-08 06:59:13 PDT
Please fix linux and mac bot failures, otherwise r+.
Comment 8 Jeremy Orlow 2010-04-08 07:14:57 PDT
Committed r57275: <http://trac.webkit.org/changeset/57275>
Comment 9 WebKit Review Bot 2010-04-08 07:53:48 PDT
http://trac.webkit.org/changeset/57275 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list:
Comment 10 Adam Barth 2010-04-08 07:56:44 PDT
The real failure is http://trac.webkit.org/changeset/57274. tkent is on it.