WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
37259
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order
https://bugs.webkit.org/show_bug.cgi?id=37259
Summary
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order
Eric Seidel (no email)
Reported
2010-04-08 02:05:24 PDT
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order fast/dom/SelectorAPI/dumpNodeList-almost-strict.html fast/dom/SelectorAPI/dumpNodeList.html For whatever reason "dump" is not always defined on the value returned from querySelectorAll. It's possible that bad prototypes are bleeding through from a previous test? Or that querySelectorAll is returning something other than an Element or a NodeList? One easy way to fix this test would be to use functions which check instanceof instead of bothering with modifying the prototypes. That way we could ASSERT in the case of objects we don't understand. Also, we could simply check for the existance of "dump" before calling it, and print some debugging message if it's not there.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-04-08 02:06:02 PDT
This was noticed while running new-run-webkit-tests which does not guarantee test order as it will run tests in parallel (by directory).
Eric Seidel (no email)
Comment 2
2010-04-08 02:50:54 PDT
Committed
r57268
: <
http://trac.webkit.org/changeset/57268
>
Eric Seidel (no email)
Comment 3
2010-04-08 02:51:24 PDT
The above commit was to update test_expectations.txt to note these tests as flaky until this bug can be fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug