Bug 37259 - fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order
Summary: fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-04-08 02:05 PDT by Eric Seidel (no email)
Modified: 2010-04-08 02:51 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-08 02:05:24 PDT
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order


For whatever reason "dump" is not always defined on the value returned from querySelectorAll.

It's possible that bad prototypes are bleeding through from a previous test?  Or that querySelectorAll is returning something other than an Element or a NodeList?

One easy way to fix this test would be to use functions which check instanceof instead of bothering with modifying the prototypes.  That way we could ASSERT in the case of objects we don't understand.

Also, we could simply check for the existance of "dump" before calling it, and print some debugging message if it's not there.
Comment 1 Eric Seidel (no email) 2010-04-08 02:06:02 PDT
This was noticed while running new-run-webkit-tests which does not guarantee test order as it will run tests in parallel (by directory).
Comment 2 Eric Seidel (no email) 2010-04-08 02:50:54 PDT
Committed r57268: <http://trac.webkit.org/changeset/57268>
Comment 3 Eric Seidel (no email) 2010-04-08 02:51:24 PDT
The above commit was to update test_expectations.txt to note these tests as flaky until this bug can be fixed.