Bug 37258 - new-run-webkit-tests should give a percent complete indication
Summary: new-run-webkit-tests should give a percent complete indication
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 01:58 PDT by Adam Barth
Modified: 2010-04-08 12:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2010-04-08 01:58 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-08 01:58:12 PDT 
new-run-webkit-tests should give a percent complete indication
Comment 1 Adam Barth 2010-04-08 01:58:35 PDT 
Created attachment 52850 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-08 01:59:31 PDT 
Comment on attachment 52850 [details]
Patch

Looks sane.
Comment 3 Adam Barth 2010-04-08 02:00:08 PDT 
Committed r57265: <http://trac.webkit.org/changeset/57265>
Comment 4 Dirk Pranke 2010-04-08 12:09:00 PDT 
Comment on attachment 52850 [details]
Patch

Personally I wouldn't bother with this change; I don't know that it adds much value to the output except to make it longer. But, it's sort of a personal preference thing ...
Comment 5 Adam Barth 2010-04-08 12:24:41 PDT 
Then you're really not going to like https://bugs.webkit.org/show_bug.cgi?id=37262 :)
Comment 6 Dirk Pranke 2010-04-08 12:31:17 PDT 
(In reply to comment #5)
> Then you're really not going to like
> https://bugs.webkit.org/show_bug.cgi?id=37262 :)

Actually, I think time remaining would be a nice addition, although I would suggest that having %age complete, time remaining, and an absolute number of tests feels a little redundant. Other comments in that bug.