Bug 37251 - Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
Summary: Rename target to configuration in new-run-webkit-tests to match the rest of W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 00:22 PDT by Adam Barth
Modified: 2010-04-08 12:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.21 KB, patch)
2010-04-08 00:23 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-08 00:22:48 PDT 
Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
Comment 1 Adam Barth 2010-04-08 00:23:43 PDT 
Created attachment 52843 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-08 00:27:32 PDT 
Comment on attachment 52843 [details]
Patch

Wow, some of this code hurts.

+    optparser.add_option('--release', action='store_const', const='Release',
+                         dest="configuration", help='Set the configuration to Debug')

should say Release.  otherwise r=me.
Comment 3 Adam Barth 2010-04-08 00:28:10 PDT 
Committed r57256: <http://trac.webkit.org/changeset/57256>
Comment 4 Eric Seidel (no email) 2010-04-08 00:29:42 PDT 
CCing Ojan in case this breaks stuff for the gardner tomrorow.
Comment 5 Adam Barth 2010-04-08 00:50:00 PDT 
Added --target back in http://trac.webkit.org/changeset/57258 to fix the downstream bots.  We should change them to use --debug or --release and then remove this evil option.
Comment 6 Dirk Pranke 2010-04-08 12:11:57 PDT 
LGTM apart from the thing you already broke and fixed ;)