Bug 37247 – Limit XML node depth

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Chris Evans]

Patch forthcoming.

[Chris Evans]

Created attachment 52833 [details]
Limit excessive XML recursion, which can cause stack overflows in various paths.

[Adam Barth]

Comment on attachment 52833 [details]
Limit excessive XML recursion, which can cause stack overflows in various paths.

ok

[WebKit Commit Bot]

Comment on attachment 52833 [details]
Limit excessive XML recursion, which can cause stack overflows in various paths.

Rejecting patch 52833 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1
Last 500 characters of output:
comparison between signed and unsigned integer expressions
distcc[50702] ERROR: compile /Users/eseidel/Projects/CommitQueue/WebCore/dom/XMLTokenizer.cpp on localhost failed
** BUILD FAILED **

The following build commands failed:
WebCore:
	Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/XMLTokenizer.o /Users/eseidel/Projects/CommitQueue/WebCore/dom/XMLTokenizer.cpp normal i386 c++ com.apple.compilers.gcc.4_2
(1 failure)


Full output: http://webkit-commit-queue.appspot.com/results/1688051

[Chris Evans]

Created attachment 52846 [details]
Fix type mismatch.

[Adam Barth]

Comment on attachment 52846 [details]
Fix type mismatch.

k

[WebKit Commit Bot]

Comment on attachment 52846 [details]
Fix type mismatch.

Clearing flags on attachment: 52846

Committed r57263: <http://trac.webkit.org/changeset/57263>

[Eric Seidel (no email)]

I am concerned this test runs too slowly.
Chromium will need to mark it as SLOW if nothing else.

[Chris Evans]

How long do you see it taking? At what timing do things be a concern?

[Alexey Proskuryakov]

*** Bug 35746 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

The test takes about a second for me on a debug build (on Mac Book Pro). This doesn't seem to be excessively slow.

[WebKit Commit Bot]

Comment on attachment 52846 [details]
Fix type mismatch.

Rejecting patch 52846 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
patching file WebCore/dom/XMLTokenizer.cpp
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 87.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/dom/XMLTokenizer.cpp.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/images/svg-nested.html
patching file LayoutTests/fast/images/svg-nested-expected.txt
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Full output: http://webkit-commit-queue.appspot.com/results/1853042

[Adam Barth]

Comment on attachment 52846 [details]
Fix type mismatch.

Clearing Eric's r+ from this patch so that it doesn't show up in pending-commit.  Please upload an updated version of this patch that applies cleanly to top of tree.

BTW, the tools say that you're not a committer, but I thought your paperwork when through.  If you're not listed in committers.py, please add yourself and feel free to land an updated version of this patch with Eric's review.

[Chris Evans]

Hi Adam,

This was already landed as per c6. Looks like the patch was added to the commit-queue twice and the second one obviously failed.
So nothing to do here.

I'll add myself to committers.py shortly.

Cheers
Chris

[Adam Barth]

If this patch as been landed, we should close the bug.