Bug 37243 - [chromium] <select> dropdowns don't die when an item is selected
Summary: [chromium] <select> dropdowns don't die when an item is selected
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Critical
Assignee: Nobody
Depends on:
Reported: 2010-04-07 17:49 PDT by Evan Stade
Modified: 2010-04-09 14:18 PDT (History)
2 users (show)

See Also:

try1 (2.06 KB, patch)
2010-04-07 17:52 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
stylefix (2.06 KB, patch)
2010-04-07 17:57 PDT, Evan Stade
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Evan Stade 2010-04-07 17:52:23 PDT
Created attachment 52813 [details]
Comment 2 Evan Stade 2010-04-07 17:55:53 PDT
this is p1 in the chromium tracker, so I'm marking importance as P1/critical. Hopefully that's the right thing to do.
Comment 3 Evan Stade 2010-04-07 17:57:35 PDT
Created attachment 52815 [details]
Comment 4 Dimitri Glazkov (Google) 2010-04-08 12:47:39 PDT
Comment on attachment 52815 [details]

r=me. Can we please add more testing around popups? We're in bad place here.
Comment 5 WebKit Commit Bot 2010-04-09 02:48:08 PDT
Comment on attachment 52815 [details]

Clearing flags on attachment: 52815

Committed r57321: <http://trac.webkit.org/changeset/57321>
Comment 6 WebKit Commit Bot 2010-04-09 02:56:45 PDT
Comment on attachment 52815 [details]

Rejecting patch 52815 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--force']" exit_code: 1
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/chromium/PopupMenuChromium.cpp
Hunk #1 FAILED at 412.
Hunk #2 FAILED at 1127.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/chromium/PopupMenuChromium.cpp.rej
patching file WebCore/platform/chromium/PopupMenuChromium.h
Hunk #1 succeeded at 154 with fuzz 2 (offset 3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/1580336