Bug 37238 – rebaseline-chromium-webkit-tests should be able to run from a webkit-only checkout

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dirk Pranke]

Currently rebaseline-chromium-webkit-tests requires the user to be running from a chromium checkout that includes webkit. It would be easier for webkit gardeners and other maintainers to be able to rebaseline ports using a webkit-only checkout.

The script currently requires a Chromium checkout for two reasons:

1) It needs to be able to check for the existence of an image_diff() binary (this method is currently only exported by the chromium ports)

2) It needs to be able to determine some basic configuration info for the platform it is trying to rebaseline (location of the test_expectations file, layout test dirs, list of test platform names, etc).

The current code distinguishes the port it is running on (e.g., "chromium-mac") from the port it is rebaselining (e.g., "chromium-win". It gets the config information from the first ("running") port and the 
baseline paths, etc. from the second ("rebaselining"). To make this really work, we need a third port object, which we'll call the "target" port. The script will use the "running" port to invoke the image diff
executable and to shell out to make directories and do other platform-specific things. It'll use the "target" port for the configuration info mentioned above, and continue to use the rebaselining port the way it
does now.

[Dirk Pranke]

Created attachment 52796 [details]
Patch

[Dirk Pranke]

Created attachment 52802 [details]
Patch

[Dirk Pranke]

Created attachment 52803 [details]
fix dangling reference to port instead of target_port, fix typo

[Dirk Pranke]

Created attachment 52807 [details]
use copy.copy() to clone the options object

[Victor Wang]

LGTM.

[Adam Barth]

Comment on attachment 52807 [details]
use copy.copy() to clone the options object

I'm relying on victorw here because he wrote this code.  Looks reasonable to me though.

[Dirk Pranke]

Committed r57290: <http://trac.webkit.org/changeset/57290>

[WebKit Review Bot]

http://trac.webkit.org/changeset/57290 might have broken SnowLeopard Intel Release (Tests)