It can be hard to debug what's going on with the python websocket server; I recently spent a few misdirected hours debugging issues because I didn't realize that there was an old websocket server already running on my machine. This change adds a --verbose flag for debug output and fixes a couple other minor nits.
Created attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging
(In reply to comment #1) > Created an attachment (id=52784) [details] > patch to add --verbose to websocket_server, slightly improve logging LGTM
How does one pass this flag? I only know run-webkit-websocketserver, which doesn't seem to forward any flags.
(In reply to comment #3) > How does one pass this flag? I only know run-webkit-websocketserver, which > doesn't seem to forward any flags. There isn't a generic new-run-webkit-websocketserver wrapper that would invoke this python code. We should probably add one. Otherwise, you would only pass this flag if you were running the script directly by hand.
Comment on attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging 241 pid = None looks unrelated.
(In reply to comment #5) > (From update of attachment 52784 [details]) > 241 pid = None > looks unrelated. Yes, it is unrelated, but it is one of the "other minor nits" referred to in my first comment.
Comment on attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging OK.
Created attachment 53722 [details] Patch
Comment on attachment 53722 [details] Patch OK.
Comment on attachment 53722 [details] Patch Clearing flags on attachment: 53722 Committed r57845: <http://trac.webkit.org/changeset/57845>
All reviewed patches have been landed. Closing bug.