RESOLVED FIXED Bug 37232
[Chromium] RTL <select> dropdown box expands to right instead of left 
https://bugs.webkit.org/show_bug.cgi?id=37232
Summary [Chromium] RTL <select> dropdown box expands to right instead of left
Xiaomei Ji
Reported 2010-04-07 14:23:40 PDT
Click the <select> box on top-right of http://news.google.com/news?ned=ar_me, and you will see the dropdown box is left-aligned with the <select> and expand to right if needed. The dropdown box will expand out of browser window, and it is got cutoff when the browser window is maximized. For RTL, the dropdown box should be right-aligned with <select> and expand to left if needed, which is the behavior of FireFox in windows.
Attachments
expected behavior (60.71 KB, image/jpeg)
2010-04-07 14:32 PDT, Xiaomei Ji 		no flags
Details
patch (1.92 KB, patch)
2010-04-09 14:58 PDT, Xiaomei Ji 		no flags
DetailsFormatted DiffDiff
patch w/ manual test (3.42 KB, patch)
2010-04-20 15:47 PDT, Xiaomei Ji 		dglazkov: review+
dglazkov: commit-queue+
DetailsFormatted DiffDiff
patch w/ manual test (3.39 KB, patch)
2010-04-20 16:02 PDT, Xiaomei Ji 		dglazkov: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xiaomei Ji
Comment 1 2010-04-07 14:32:01 PDT
Created attachment 52783 [details] expected behavior
Xiaomei Ji
Comment 2 2010-04-07 14:34:06 PDT
related chromium bug: http://code.google.com/p/chromium/issues/detail?id=40582
Xiaomei Ji
Comment 3 2010-04-09 14:58:57 PDT
Created attachment 52994 [details] patch
Xiaomei Ji
Comment 4 2010-04-09 15:01:27 PDT
Jay reviewed the patch in chromium's codereview site: http://codereview.chromium.org/1621011/show
Dimitri Glazkov (Google)
Comment 5 2010-04-20 10:39:09 PDT
Comment on attachment 52994 [details] patch > > + // Adjust the starting x-axis for RTL dropdown. For RTL dropdown, the right edge > + // of dropdown box should be aligned with the right edge of <select> element box, > + // and the dropdown box should be expanded to left if more space needed. > + bool rightAligned = m_listBox->m_popupClient->menuStyle().textDirection() == RTL; Can m_popupClient be 0 here? > + if (rightAligned) > + move(x() + popupWidth - listBoxWidth, y()); > > invalidate(); > }
Xiaomei Ji
Comment 6 2010-04-20 15:47:41 PDT
Created attachment 53899 [details] patch w/ manual test
Xiaomei Ji
Comment 7 2010-04-20 15:48:16 PDT
(In reply to comment #5) > (From update of attachment 52994 [details]) > > > > + // Adjust the starting x-axis for RTL dropdown. For RTL dropdown, the right edge > > + // of dropdown box should be aligned with the right edge of <select> element box, > > + // and the dropdown box should be expanded to left if more space needed. > > + bool rightAligned = m_listBox->m_popupClient->menuStyle().textDirection() == RTL; > > Can m_popupClient be 0 here? I do not think it can be 0 here. But I added a NULL check for safe. > > > + if (rightAligned) > > + move(x() + popupWidth - listBoxWidth, y()); > > > > invalidate(); > > }
Dimitri Glazkov (Google)
Comment 8 2010-04-20 15:58:27 PDT
Comment on attachment 53899 [details] patch w/ manual test ok.
Xiaomei Ji
Comment 9 2010-04-20 16:02:31 PDT
Created attachment 53903 [details] patch w/ manual test
Dimitri Glazkov (Google)
Comment 10 2010-04-20 16:22:23 PDT
Comment on attachment 53903 [details] patch w/ manual test per author's request.
Xiaomei Ji
Comment 11 2010-04-21 10:36:07 PDT
Manually committed r57992: http://trac.webkit.org/changeset/57992
Note You need to log in before you can comment on or make changes to this bug.