Bug 37226 - [Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
Summary: [Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-04-07 11:57 PDT by Jarkko Sakkinen
Modified: 2010-04-08 03:40 PDT (History)
2 users (show)

See Also:


Attachments
Removes appending of precision and version from shaderSource (1.91 KB, patch)
2010-04-07 12:45 PDT, Jarkko Sakkinen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jarkko Sakkinen 2010-04-07 11:57:14 PDT
Remove ugly hack from GraphicsContext3D::shadeSource implementation that appends #version to shaderSource. This is all wrong and mistake by me when I first did it and it breaks lot of WebGL pages. Making sure that shader source meets WebGL specification must be handled in platform independent WebGL code.
Comment 1 Jarkko Sakkinen 2010-04-07 12:45:09 PDT
Created attachment 52771 [details]
Removes appending of precision and version from shaderSource
Comment 2 WebKit Commit Bot 2010-04-08 02:23:07 PDT
Comment on attachment 52771 [details]
Removes appending of precision and version from shaderSource

Clearing flags on attachment: 52771

Committed r57267: <http://trac.webkit.org/changeset/57267>
Comment 3 WebKit Commit Bot 2010-04-08 02:23:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2010-04-08 03:40:15 PDT
Revision r57267 cherry-picked into qtwebkit-2.0 with commit 26ec2a2b5376ffc5810a52d5476d51ca9b860a36