Bug 37199 - [WINCE] Add missing headers
Summary: [WINCE] Add missing headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 03:26 PDT by Young Han Lee
Modified: 2010-04-08 07:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.53 KB, patch)
2010-04-07 03:29 PDT, Young Han Lee 		no flags Details | Formatted Diff | Diff
Now with style issue fixed (3.55 KB, patch)
2010-04-07 05:37 PDT, Young Han Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Young Han Lee 2010-04-07 03:26:03 PDT 
Include necessary headers. They are omitted because the build system used precompiled header.
Comment 1 Young Han Lee 2010-04-07 03:29:06 PDT 
Created attachment 52722 [details]
Patch
Comment 2 WebKit Review Bot 2010-04-07 03:36:32 PDT 
Attachment 52722 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Young Han Lee 2010-04-07 05:37:24 PDT 
Created attachment 52731 [details]
Now with style issue fixed
Comment 4 WebKit Commit Bot 2010-04-08 07:05:22 PDT 
Comment on attachment 52731 [details]
Now with style issue fixed

Clearing flags on attachment: 52731

Committed r57273: <http://trac.webkit.org/changeset/57273>
Comment 5 WebKit Commit Bot 2010-04-08 07:05:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-04-08 07:53:37 PDT 
http://trac.webkit.org/changeset/57273 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/57273
http://trac.webkit.org/changeset/57275
Comment 7 Adam Barth 2010-04-08 07:56:17 PDT 
The failure is really http://trac.webkit.org/changeset/57274.  tkent is on it.