Bug 37193 - [chromium] implement getData('text/html') for paste and drop events
Summary: [chromium] implement getData('text/html') for paste and drop events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 01:45 PDT by Tony Chang
Modified: 2010-04-11 19:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.30 KB, patch)
2010-04-07 01:47 PDT, Tony Chang
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-04-07 01:45:38 PDT
[chromium] implement getData('text/html') for paste and drop events
Comment 1 Tony Chang 2010-04-07 01:47:05 PDT
Created attachment 52713 [details]
Patch
Comment 2 Tony Chang 2010-04-07 01:49:12 PDT
The webkit mac side is here: https://bugs.webkit.org/show_bug.cgi?id=19893

I can try to make this work in safari win too (seems straightforward).

Bug https://bugs.webkit.org/show_bug.cgi?id=37193 is related, but it's for general types (and would involve some IPC plumbing to allow arbitrary types through).
Comment 3 Eric Seidel (no email) 2010-04-09 13:57:12 PDT
Comment on attachment 52713 [details]
Patch

Looks reasonable to me.
Comment 4 Eric Seidel (no email) 2010-04-09 13:57:39 PDT
CCing Oliver (who has worked on mac DnD) so he sees this go by.
Comment 5 Tony Chang 2010-04-11 18:44:00 PDT
Comment on attachment 52713 [details]
Patch

Watching the landing since I'm not sure if it'll pass or fail on QT.
Comment 6 WebKit Commit Bot 2010-04-11 19:08:01 PDT
Comment on attachment 52713 [details]
Patch

Rejecting patch 52713 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
-html.html
patching file LayoutTests/platform/gtk/Skipped
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 151.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej
patching file LayoutTests/platform/win/Skipped
Hunk #1 FAILED at 822.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/win/Skipped.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/chromium/ClipboardChromium.cpp

Full output: http://webkit-commit-queue.appspot.com/results/1610409
Comment 7 Tony Chang 2010-04-11 19:22:07 PDT
Committed r57464: <http://trac.webkit.org/changeset/57464>