Bug 37182 - WebCore config.h hardcodes the wince OS policies.
Summary: WebCore config.h hardcodes the wince OS policies.
Status: RESOLVED DUPLICATE of bug 49887
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-06 18:16 PDT by JasonR
Modified: 2010-11-23 07:47 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch (501 bytes, patch)
2010-04-06 18:43 PDT, JasonR
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JasonR 2010-04-06 18:16:15 PDT
I'm looking to start submitting changes to support the Windows CE platform; I picked this as a first change so that I can see the patch review process through; hopefully without affecting anything.

The following definition in config.h forces OS(WINCE) into a set of policies on building that cannot be overriden easily to be different to the windows build.

#if PLATFORM(WIN)
#if defined(WIN_CAIRO)
#undef WTF_PLATFORM_CG
#define WTF_PLATFORM_CAIRO 1
#undef WTF_USE_CFNETWORK
#define WTF_USE_CURL 1
#ifndef _WINSOCKAPI_
#define _WINSOCKAPI_ // Prevent inclusion of winsock.h in windows.h
#endif
#else
#define WTF_PLATFORM_CG 1
#undef WTF_PLATFORM_CAIRO
#define WTF_USE_CFNETWORK 1
#undef WTF_USE_CURL
#endif
#undef WTF_USE_WININET
#define WTF_PLATFORM_CF 1
#define WTF_USE_PTHREADS 0
#endif

I would like to change this to 

#if PLATFORM(WIN) && !OS(WINCE)

so that WINCE can set the policies in wtf/platform.h (or have them overriden from the default); especially items like using WININET and WTF_PLATFORM_CF which are not available on windows CE.  I am using a build that is windows CE for CAIRO+WININET+PTHREADS and these hardcoded values for the policies for PLATFORM(WIN) don't allow options for the build configuration.

I have a patch for this change available.
Comment 1 JasonR 2010-04-06 18:43:21 PDT
Created attachment 52693 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2010-04-06 19:25:44 PDT
Comment on attachment 52693 [details]
Proposed patch

r- for lack of ChangeLog, see http://webkit.org/coding/contributing.html
Comment 3 Patrick R. Gansterer 2010-11-23 07:47:05 PST

*** This bug has been marked as a duplicate of bug 49887 ***