WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
37173
[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
https://bugs.webkit.org/show_bug.cgi?id=37173
Summary
[Qt] The build system is not installing the generated headers (QGraphicsWebVi...
Rodrigo Belem
Reported
2010-04-06 15:39:13 PDT
The build system is installing everything fine apart from some headers, like QGraphicsWebView QWebDatabase, etc. It is important to have the build system install these files because qtwebkit-2.0 now builds separately from qt. * Building qtwebkit cmd: WebKitTools/Scripts/build-webkit --qt * Installing cmd: cd WebKitBuild/Release/ make install
Attachments
Patch that fixes this bug.
(1.81 KB, patch)
2010-04-06 16:15 PDT
,
Rodrigo Belem
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rodrigo Belem
Comment 1
2010-04-06 16:15:22 PDT
Created
attachment 52680
[details]
Patch that fixes this bug. Trivial patch that replaces the .. by the $$OUTPUT_DIR.
Rodrigo Belem
Comment 2
2010-04-06 16:16:57 PDT
Adding Qt to the Keywords.
Jocelyn Turcotte
Comment 3
2010-04-07 05:51:53 PDT
(In reply to
comment #1
)
> Created an attachment (id=52680) [details] > Patch that fixes this bug. > > Trivial patch that replaces the .. by the $$OUTPUT_DIR.
I like the patch because it makes things clearer, however I don't understand why this fixes your issue since $$OUTPUT_DIR == .. I probably miss something in the picture, do you have more information on why it helps?
Simon Hausmann
Comment 4
2010-04-07 05:57:01 PDT
Comment on
attachment 52680
[details]
Patch that fixes this bug. Looks good to me and Jocelyn (we just discussed it in the office :) Thanks Rodrigo!
WebKit Commit Bot
Comment 5
2010-04-07 09:44:00 PDT
Comment on
attachment 52680
[details]
Patch that fixes this bug. Clearing flags on attachment: 52680 Committed
r57213
: <
http://trac.webkit.org/changeset/57213
>
WebKit Commit Bot
Comment 6
2010-04-07 09:44:06 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 7
2010-04-08 00:53:57 PDT
Revision
r57213
cherry-picked into qtwebkit-2.0 with commit 33c7a75414a4847b395f4ac78527e7d137a844f6
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug