chrome side is here: http://codereview.chromium.org/1520014 layout test run is here: http://build.chromium.org/buildbot/try-server/buildstatus?builder=layout_linux&number=1664
Created attachment 52665 [details] try1
ChangeLog should mention if it's covered by tests or what new tests cover it.
I don't know if we have the infrastructure for running printing tests on chromium. From test_expectations.txt: // These tests try to print a PDF file as the expected result. I don't think // we plan on supporting this anytime soon. WONTFIX SKIP : printing/media-queries-print.html = PASS WONTFIX SKIP : printing/compositing-layer-printing.html = PASS
No one runs those printing tests, sadly. PDFs are not portable. Some folks in the TKO office were working on printing support though.
+darin, levin need this for mstone 5.
Created attachment 53000 [details] update changelog updated changelog to explain test situation.
Comment on attachment 53000 [details] update changelog Well, there are other ways than pdfs these days. But OK. You should be sure to notify the TKO folks and perhaps they can help you come up with a test after the fact.
> Well, there are other ways than pdfs these days. But OK. You should be sure > to notify the TKO folks and perhaps they can help you come up with a test after > the fact. I think we cannot test this for now. Once I finish Bug 37203 and Bug 20011, this patch should be able to be tested by image diff. I'll add a test case for this patch, so please wait for a while. When I post a patch to test this change, I'll CC Evan to make sure the test is suitable for this issue.
thanks a ton :)
Comment on attachment 53000 [details] update changelog Clearing flags on attachment: 53000 Committed r57402: <http://trac.webkit.org/changeset/57402>
All reviewed patches have been landed. Closing bug.