Bug 37168 - [chromium] Linux: respect the scale factor during printing
Summary: [chromium] Linux: respect the scale factor during printing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-06 13:47 PDT by Evan Stade
Modified: 2010-04-09 19:50 PDT (History)
7 users (show)

See Also:


Attachments
try1 (1.78 KB, patch)
2010-04-06 13:49 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
update changelog (1.91 KB, patch)
2010-04-09 15:21 PDT, Evan Stade
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Evan Stade 2010-04-06 13:49:14 PDT
Created attachment 52665 [details]
try1
Comment 2 Evan Martin 2010-04-06 13:55:04 PDT
ChangeLog should mention if it's covered by tests or what new tests cover it.
Comment 3 Evan Stade 2010-04-06 14:03:25 PDT
I don't know if we have the infrastructure for running printing tests on chromium. From test_expectations.txt:

// These tests try to print a PDF file as the expected result.  I don't think
// we plan on supporting this anytime soon.
WONTFIX SKIP : printing/media-queries-print.html = PASS
WONTFIX SKIP : printing/compositing-layer-printing.html = PASS
Comment 4 Eric Seidel (no email) 2010-04-06 18:59:53 PDT
No one runs those printing tests, sadly.  PDFs are not portable.  Some folks in the TKO office were working on printing support though.
Comment 5 Evan Stade 2010-04-08 13:36:22 PDT
+darin, levin

need this for mstone 5.
Comment 6 Evan Stade 2010-04-09 15:21:37 PDT
Created attachment 53000 [details]
update changelog

updated changelog to explain test situation.
Comment 7 Eric Seidel (no email) 2010-04-09 15:23:21 PDT
Comment on attachment 53000 [details]
update changelog

Well, there are other ways than pdfs these days.  But OK.  You should be sure to notify the TKO folks and perhaps they can help you come up with a test after the fact.
Comment 8 Shinichiro Hamaji 2010-04-09 15:45:07 PDT
> Well, there are other ways than pdfs these days.  But OK.  You should be sure
> to notify the TKO folks and perhaps they can help you come up with a test after
> the fact.

I think we cannot test this for now. Once I finish Bug 37203 and Bug 20011, this patch should be able to be tested by image diff. I'll add a test case for this patch, so please wait for a while. When I post a patch to test this change, I'll CC Evan to make sure the test is suitable for this issue.
Comment 9 Evan Stade 2010-04-09 15:49:03 PDT
thanks a ton :)
Comment 10 WebKit Commit Bot 2010-04-09 19:50:11 PDT
Comment on attachment 53000 [details]
update changelog

Clearing flags on attachment: 53000

Committed r57402: <http://trac.webkit.org/changeset/57402>
Comment 11 WebKit Commit Bot 2010-04-09 19:50:17 PDT
All reviewed patches have been landed.  Closing bug.