Bug 37160 - [V8] Throw exception in SerializedScriptValue on input errors
Summary: [V8] Throw exception in SerializedScriptValue on input errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-06 10:43 PDT by Vitaly Repeshko
Modified: 2010-04-07 07:05 PDT (History)
0 users

See Also:

Attachments
patch v1 (12.42 KB, patch)
2010-04-06 10:48 PDT, Vitaly Repeshko 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2010-04-06 10:43:25 PDT 
[V8] Throw exception in SerializedScriptValue on input errors
Comment 1 Vitaly Repeshko 2010-04-06 10:48:51 PDT 
Created attachment 52650 [details]
patch v1
Comment 2 Yury Semikhatsky 2010-04-07 00:08:01 PDT 
Comment on attachment 52650 [details]
patch v1

> -    explicit SerializedScriptValue(v8::Handle<v8::Value>);
> +    SerializedScriptValue(v8::Handle<v8::Value>, bool& didThrow);
> 
I don't like the idea of out parameter in the constructor but since it's private I think that is ok.
Comment 3 Vitaly Repeshko 2010-04-07 07:05:32 PDT 
	M	WebCore/ChangeLog
	M	WebCore/bindings/scripts/CodeGeneratorV8.pm
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
	M	WebCore/bindings/v8/SerializedScriptValue.h
	M	WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
	M	WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp
	M	WebCore/bindings/v8/custom/V8HistoryCustom.cpp
	M	WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
	M	WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
	M	WebCore/bindings/v8/custom/V8WorkerCustom.cpp
Committed r57207