Bug 37152 – [Qt] Rendering artifacts on Qt plugins when scrolling the page

• Status: CLOSED
• Resolution: FIXED
• Component: Plug-ins

When having plugins on a QWebView, scrolling the view does not update the painting of the plugins correctly.
The plugin rect leaves vertical lines when scrolling back up, where the plugin was previously visible.

Created attachment 52640 [details]
archive containing entire project

To reproduce the issue, drag the html file from the debug directory onto the view.
Scroll the page up and down.

[Andreas Kling]

Created attachment 52685 [details]
Always repaint QtPluginWidgets on geometry change

[Andreas Kling]

This is a regression caused by https://bugs.webkit.org/show_bug.cgi?id=33373

(The previous behavior was to repaint the entire viewport when scrolling a page with plugins.)

[Simon Hausmann]

Comment on attachment 52685 [details]
Always repaint QtPluginWidgets on geometry change

> diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
> index 5d014d2..09a4573 100644
> --- a/WebKit/qt/ChangeLog
> +++ b/WebKit/qt/ChangeLog
> @@ -1,3 +1,12 @@
> [phone]  Andreas Kling  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Always repaint QtPluginWidgets when their geometry changes.
> +        https://bugs.webkit.org/show_bug.cgi?id=37152
> +
> +        * WebCoreSupport/FrameLoaderClientQt.cpp:

Patch looks good to me, but please include the bug title in the ChangeLog, so that
it's clear from the ChangeLog what higher level issue is fixed.

The usual format is

    [Qt] Baz isn't repainted correctly after Foo
    https://bugs.webkit.org/...

    Because Foo is too small we also need to repaint
    Baz.

    ....

[Kenneth Rohde Christiansen]

> The usual format is
> 
>     [Qt] Baz isn't repainted correctly after Foo
>     https://bugs.webkit.org/...

You can also use the "http://webkit.org/b/BUGNUMBER" shorthand.

[Benjamin Poulain]

> Patch looks good to me, but please include the bug title in the ChangeLog, so
> that
> it's clear from the ChangeLog what higher level issue is fixed.

prepare-changelog --bug 37152
can also do the trick :)

[Andreas Kling]

Created attachment 53293 [details]
Patch with better ChangeLog

[WebKit Commit Bot]

Comment on attachment 53293 [details]
Patch with better ChangeLog

Clearing flags on attachment: 53293

Committed r57623: <http://trac.webkit.org/changeset/57623>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Revision r57623 cherry-picked into qtwebkit-2.0 with commit 213eb62e284938447916392220e645631fb9cf3d