Bug 37150 - [V8][Android] PageCache crashes when JavaScript is disabled
Summary: [V8][Android] PageCache crashes when JavaScript is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-06 06:58 PDT by Andrei Popescu
Modified: 2010-04-06 10:49 PDT (History)
3 users (show)

See Also:

Attachments
Check the context to avoid crashing when it's null. (2.11 KB, patch)
2010-04-06 07:04 PDT, Andrei Popescu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-04-06 06:58:54 PDT 
WebKit's Page Cache mechanism always attempts to save the script state, regardless of whether JavaScript is enabled or not in the browser. When JS is disabled, a frame's JS execution context is null. However, the Android V8 bindings always expect it to be non-null. The saving and restoration of the script state should be a no-op when JS is disabled. Patch coming.
Comment 1 Andrei Popescu 2010-04-06 07:04:25 PDT 
Created attachment 52633 [details]
Check the context to avoid crashing when it's null.
Comment 2 Dimitri Glazkov (Google) 2010-04-06 08:31:08 PDT 
Comment on attachment 52633 [details]
Check the context to avoid crashing when it's null.

ok.
Comment 3 WebKit Commit Bot 2010-04-06 10:49:41 PDT 
Comment on attachment 52633 [details]
Check the context to avoid crashing when it's null.

Clearing flags on attachment: 52633

Committed r57157: <http://trac.webkit.org/changeset/57157>
Comment 4 WebKit Commit Bot 2010-04-06 10:49:48 PDT 
All reviewed patches have been landed.  Closing bug.