Bug 37149 - JS code generator does not support feature conditional attributes that are writable
Summary: JS code generator does not support feature conditional attributes that are wr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Simon Hausmann
Keywords: Qt
Depends on:
Blocks: 36750
  Show dependency treegraph
Reported: 2010-04-06 06:44 PDT by Simon Hausmann
Modified: 2010-04-07 00:48 PDT (History)
5 users (show)

See Also:

Patch (2.20 KB, patch)
2010-04-06 06:55 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2010-04-06 06:44:27 PDT
When using the conditional keyword for attributes that can be written, then the generated code is missing the feature #ifdefs for the setter functions. The getter functions do have the correct #ifdefs in place.

For example:

        attribute [Conditional=TOUCH_EVENTS] EventListener ontouchstart;
Comment 1 Simon Hausmann 2010-04-06 06:55:27 PDT
Created attachment 52631 [details]
Comment 2 WebKit Commit Bot 2010-04-06 12:51:06 PDT
Comment on attachment 52631 [details]

Clearing flags on attachment: 52631

Committed r57163: <http://trac.webkit.org/changeset/57163>
Comment 3 WebKit Commit Bot 2010-04-06 12:51:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-04-06 13:54:00 PDT
http://trac.webkit.org/changeset/57163 might have broken Tiger Intel Release
Comment 5 Adam Barth 2010-04-06 13:56:17 PDT
Sorry for the noise.  You're running into https://bugs.webkit.org/show_bug.cgi?id=37145.
Comment 6 Simon Hausmann 2010-04-07 00:48:37 PDT
Revision r57163 cherry-picked into qtwebkit-2.0 with commit 6dcb7f961c5941963b288f5fc4ef3c64877f62ae