WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
37121
REGRESSION(
r57081
): We think it triggered two tests to fail on Tiger because of race conditions (Requested by abarth on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=37121
Summary
REGRESSION(r57081): We think it triggered two tests to fail on Tiger because ...
WebKit Review Bot
Reported
2010-04-05 15:51:21 PDT
http://trac.webkit.org/changeset/57081
broke the build: We think it triggered two tests to fail on Tiger because of race conditions (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r57081
(10.33 KB, patch)
2010-04-05 15:51 PDT
,
WebKit Review Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2010-04-05 15:51:40 PDT
Created
attachment 52584
[details]
ROLLOUT of
r57081
Adam Barth
Comment 2
2010-04-05 16:07:39 PDT
Comment on
attachment 52584
[details]
ROLLOUT of
r57081
Clearing flags on attachment: 52584 Committed
r57100
: <
http://trac.webkit.org/changeset/57100
>
Adam Barth
Comment 3
2010-04-05 16:07:45 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 4
2010-04-05 16:10:10 PDT
This also affected Qt. Ossy reproduced the failure locally and confirmed that the rollout caused the failure to go away. I've not yet been able to reproduce the failure on Leopard. I don't have access to a Tiger machine.
Eric Seidel (no email)
Comment 5
2010-04-05 16:11:35 PDT
Our understanding of this failure is that this regression made it possible for load events to fire on the outermost document, before the inner <object> elements had a chance to schedule their loads. <object> load scheduling is crazy. it happens in the renderers via updateWidget which is scheduled from attach().
Eric Seidel (no email)
Comment 6
2010-04-05 16:30:07 PDT
Looks like this rollout fixed both the Qt bot and Tiger.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug