Bug 37111 – Draw replacement text when plug-in host crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Alexey Proskuryakov]

Currently, it's just an empty space.

[Alexey Proskuryakov]

<rdar://problem/7790327>

[Alexey Proskuryakov]

Created attachment 52566 [details]
proposed patch

[Darin Adler]

Comment on attachment 52566 [details]
proposed patch

>      , m_showsMissingPluginIndicator(false)
> +    , m_showsCrashedPluginIndicator(false)

An enum would be better than two booleans. We never want to show both.

>      void setShowsMissingPluginIndicator(bool showsMissingPluginIndicator) { m_showsMissingPluginIndicator = showsMissingPluginIndicator; }
>      bool showsMissingPluginIndicator() const { return m_showsMissingPluginIndicator; }
> +    void setShowsCrashedPluginIndicator(bool showsCrashedPluginIndicator) { m_showsCrashedPluginIndicator = showsCrashedPluginIndicator; }
> +    bool showsCrashedPluginIndicator() const { return m_showsCrashedPluginIndicator; }

I know that someone (Simon) suggested adding the getter to Kevin's original patch, but I don't think we need the getters. Nor do I think we need a way to set either value to false.

> [phone]  Alexey Proskuryakov  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=37111
> +        <rdar://problem/7790327> Draw replacement text when plug-in host crashes
> +
> +        * English.lproj/Localizable.strings: Added a string for plug-in failure.
> +
> [phone]  Alexey Proskuryakov  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        * English.lproj/Localizable.strings:
> +

Double change log.

I think this will break the build on platforms other than Mac because the crashedPluginText function will be called, but not defined.

An interesting way to sidestep that would be to have the API take a string and have WebHostedNetscapePluginView pass the string in. Then you'd use a String instead of an enum in RenderEmbeddedObject.

r=me as long as you make it build on non-Mac platforms

[WebKit Review Bot]

Attachment 52566 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1652169

[Early Warning System Bot]

Attachment 52566 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1550283

[Alexey Proskuryakov]

Created attachment 52575 [details]
updated patch

Updated patch. I chose to keep a common mechanism for both localized strings, since other ports may want to support out of process plug-ins.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/57095>.