Bug 37106 - Turns out commit_info.committer() can be None
Summary: Turns out commit_info.committer() can be None
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2010-04-05 12:45 PDT by Adam Barth
Modified: 2010-04-06 23:46 PDT (History)
4 users (show)

See Also:

Patch (4.92 KB, patch)
2010-04-05 12:46 PDT, Adam Barth
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-05 12:45:31 PDT
Turns out commit_info.committer() can be None
Comment 1 Adam Barth 2010-04-05 12:46:37 PDT
Created attachment 52558 [details]
Comment 2 Eric Seidel (no email) 2010-04-05 12:49:44 PDT
Comment on attachment 52558 [details]

Comment 3 WebKit Commit Bot 2010-04-06 00:18:44 PDT
Comment on attachment 52558 [details]

Rejecting patch 52558 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.py
patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py
Hunk #1 succeeded at 87 with fuzz 2.
patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py.rej
patching file WebKitTools/Scripts/webkitpy/tool/commands/queries.py

Full output: http://webkit-commit-queue.appspot.com/results/1533270
Comment 4 WebKit Review Bot 2010-04-06 01:14:27 PDT
http://trac.webkit.org/changeset/57132 might have broken Tiger Intel Release
Comment 5 Eric Seidel (no email) 2010-04-06 23:45:46 PDT
Attachment 52558 [details] was posted by a committer and has review+, assigning to Adam Barth for commit.