Bug 37103 - assorted helper functions and cleanup of git utilities
Summary: assorted helper functions and cleanup of git utilities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 36394
  Show dependency tree / graph
 
Reported: 2010-04-05 11:57 PDT by Ojan Vafai
Modified: 2010-04-08 17:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.61 KB, patch)
2010-04-05 12:01 PDT, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-04-05 11:57:26 PDT 
assorted helper functions and cleanup of git utilities
Comment 1 Ojan Vafai 2010-04-05 12:01:49 PDT 
Created attachment 52551 [details]
Patch
Comment 2 WebKit Review Bot 2010-04-05 12:04:03 PDT 
Attachment 52551 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:211:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ojan Vafai 2010-04-05 12:06:11 PDT 
(In reply to comment #2)
> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:211:  deprecated form of
> raising exception  [pep8/W602] [5]

Not sure what the correct form of raising an exception is, but this is certainly consistent with the bzillion other such cases in this file. Not fixing now. This should probably be fixed throughout the file at once.
Comment 4 Eric Seidel (no email) 2010-04-05 12:16:45 PDT 
Comment on attachment 52551 [details]
Patch

OK.
Comment 5 Eric Seidel (no email) 2010-04-06 23:45:40 PDT 
Attachment 52551 [details] was posted by a committer and has review+, assigning to Ojan Vafai for commit.
Comment 6 Ojan Vafai 2010-04-08 17:35:18 PDT 
http://trac.webkit.org/changeset/57091