Bug 37088 - Fix some "explicit braces to avoid ambiguous 'else'" warnings
Summary: Fix some "explicit braces to avoid ambiguous 'else'" warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-05 08:42 PDT by Antonio Gomes
Modified: 2010-04-05 08:55 PDT (History)
1 user (show)

See Also:


Attachments
(committed in r57077) patch (2.72 KB, patch)
2010-04-05 08:45 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-04-05 08:42:52 PDT
it'd be good shut up some compiler warnings.

./../../../WebCore/dom/Node.cpp: In member function 'bool WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>)':
../../../../WebCore/dom/Node.cpp:2614: warning: suggest explicit braces to avoid ambiguous 'else'
uninitialized in this function

(...)
../../../../WebCore/page/DOMWindow.cpp: In member function 'bool WebCore::DOMWindow::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::EventTarget>)':
../../../../WebCore/page/DOMWindow.cpp:1437: warning: suggest explicit braces to avoid ambiguous 'else'
../../../../WebCore/platform/UUID.cpp: In function 'WebCore::String WebCore::createCanonicalUUIDString()':
Comment 1 Antonio Gomes 2010-04-05 08:45:12 PDT
Created attachment 52536 [details]
(committed in r57077) patch
Comment 2 Darin Adler 2010-04-05 08:45:51 PDT
Comment on attachment 52536 [details]
(committed in r57077) patch

These are braces, not parentheses. I'm happy that the compiler warnings happen to match our coding style.
Comment 3 Antonio Gomes 2010-04-05 08:48:38 PDT
thx darin! i will fix ChangeLog before landing