Bug 37083 - [Qt] [Symbian] Remove obsolete build flags for Symbian
: [Qt] [Symbian] Remove obsolete build flags for Symbian
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: PC S60 3rd edition
: P2 Normal
Assigned To: Nobody
: Qt
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-05 06:12 PDT by Laszlo Gombos
Modified: 2010-04-05 10:26 PDT (History)
4 users (show)

See Also:


Attachments
proposed change (1.32 KB, patch)
2010-04-05 06:26 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-04-05 06:12:32 PDT
WebCore/config.h contains some obsolete code that was checked in r23281 3 years ago.
Comment 1 Laszlo Gombos 2010-04-05 06:26:52 PDT
Created attachment 52530 [details]
proposed change
Comment 2 Kenneth Rohde Christiansen 2010-04-05 06:28:21 PDT
Comment on attachment 52530 [details]
proposed change

I'll trust you on this one.
Comment 3 WebKit Commit Bot 2010-04-05 06:47:42 PDT
Comment on attachment 52530 [details]
proposed change

Clearing flags on attachment: 52530

Committed r57074: <http://trac.webkit.org/changeset/57074>
Comment 4 WebKit Commit Bot 2010-04-05 06:47:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-04-05 07:28:31 PDT
http://trac.webkit.org/changeset/57074 might have broken Leopard Intel Release (Tests)
Comment 6 Laszlo Gombos 2010-04-05 08:49:36 PDT
I do not think this commit changed anything for Leopard. The failed test seems to be a flaky xhr test that timed out. I'm happy to roll out the patch though if others thing otherwise.
Comment 7 Eric Seidel 2010-04-05 10:26:46 PDT
Sorry for the noise.  Bug 37077 struck twice in a row. :(