Bug 37080 - RenderProgress.cpp is missing CurrentTime.h
Summary: RenderProgress.cpp is missing CurrentTime.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-05 03:41 PDT by Hajime Morrita
Modified: 2010-04-05 23:59 PDT (History)
2 users (show)

See Also:


Attachments
v0; should be trivial (890 bytes, patch)
2010-04-05 03:48 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
move inclusion to RenderProgress.cpp (911 bytes, patch)
2010-04-05 04:56 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-04-05 03:41:27 PDT
On Chromium port, there is a compilation error when PROGRESS_TAG enabled, 
because RenderProgress.h is missing CurrentTime.h.
Comment 1 Hajime Morrita 2010-04-05 03:48:56 PDT
Created attachment 52524 [details]
v0; should be trivial
Comment 2 Hajime Morrita 2010-04-05 03:49:57 PDT
Qt port may include it somewhere in port specific file.
Comment 3 Mark Rowe (bdash) 2010-04-05 04:14:55 PDT
Comment on attachment 52524 [details]
v0; should be trivial

CurrentTime.h not used within the header file.  It should only be included where it’s used.
Comment 4 Hajime Morrita 2010-04-05 04:56:28 PDT
Created attachment 52525 [details]
move inclusion to RenderProgress.cpp
Comment 5 Hajime Morrita 2010-04-05 04:58:23 PDT
bdash, thank you for reviewing. And you are definitely right.

> CurrentTime.h not used within the header file.  It should only be included
> where it’s used.
Fixed to move inclusion to RenderProgress.cpp
I also updated the bug summary to reflect that.
Comment 6 Darin Adler 2010-04-05 08:35:46 PDT
Comment on attachment 52525 [details]
move inclusion to RenderProgress.cpp

Doesn't the file also need to include <math.h> or <wtf/MathExtras.h>?
Comment 7 Hajime Morrita 2010-04-05 18:33:28 PDT
(In reply to comment #6)
> (From update of attachment 52525 [details])
> Doesn't the file also need to include <math.h> or <wtf/MathExtras.h>?
I'm not sure. Chromium is successfully built only with CurrentTime.h. 
math.h might be included somewhere else.
Comment 8 WebKit Commit Bot 2010-04-05 23:59:46 PDT
Comment on attachment 52525 [details]
move inclusion to RenderProgress.cpp

Clearing flags on attachment: 52525

Committed r57130: <http://trac.webkit.org/changeset/57130>
Comment 9 WebKit Commit Bot 2010-04-05 23:59:50 PDT
All reviewed patches have been landed.  Closing bug.