Bug 37068 - Change UString to use a 0 rep for null strings instead a null object.
Summary: Change UString to use a 0 rep for null strings instead a null object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-03 21:33 PDT by Gavin Barraclough
Modified: 2010-04-03 23:54 PDT (History)
1 user (show)

See Also:


Attachments
The patch (6.73 KB, patch)
2010-04-03 21:34 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-04-03 21:33:15 PDT
(as per WebCore::String)
Comment 1 Gavin Barraclough 2010-04-03 21:34:57 PDT
Created attachment 52502 [details]
The patch

No performance impact
Comment 2 WebKit Review Bot 2010-04-03 21:36:50 PDT
Attachment 52502 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/UString.h:142:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/runtime/UString.h:142:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-04-03 22:19:47 PDT
Comment on attachment 52502 [details]
The patch

r=me, but you need to fix the style error in UString::cost
Comment 4 Gavin Barraclough 2010-04-03 23:54:14 PDT
Transmitting file data ......
Committed revision 57055.