Bug 37064 - check-webkit-style: refactor the option-parsing code
Summary: check-webkit-style: refactor the option-parsing code
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
Depends on:
Reported: 2010-04-03 14:06 PDT by Chris Jerdonek
Modified: 2010-04-04 01:27 PDT (History)
3 users (show)

See Also:

Proposed patch (14.62 KB, patch)
2010-04-03 14:24 PDT, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-04-03 14:06:27 PDT
There is some minor refactoring the option-parsing code could use.  This includes one FIXME and some other things.
Comment 1 Chris Jerdonek 2010-04-03 14:24:45 PDT
Created attachment 52501 [details]
Proposed patch
Comment 2 Shinichiro Hamaji 2010-04-04 00:15:40 PDT
Comment on attachment 52501 [details]
Proposed patch

Looks good!
Comment 3 WebKit Commit Bot 2010-04-04 00:44:24 PDT
Comment on attachment 52501 [details]
Proposed patch

Rejecting patch 52501 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12625 test cases.
fast/canvas/webgl/drawArraysOutOfBounds.html -> failed

Exiting early after 1 failures. 5073 tests run.
88.37s total testing time

5072 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1553245
Comment 4 Chris Jerdonek 2010-04-04 01:27:05 PDT
Comment on attachment 52501 [details]
Proposed patch

Clearing flags on attachment: 52501

Committed r57056: <http://trac.webkit.org/changeset/57056>
Comment 5 Chris Jerdonek 2010-04-04 01:27:11 PDT
All reviewed patches have been landed.  Closing bug.