There is some minor refactoring the option-parsing code could use. This includes one FIXME and some other things.
Created attachment 52501 [details] Proposed patch
Comment on attachment 52501 [details] Proposed patch Looks good!
Comment on attachment 52501 [details] Proposed patch Rejecting patch 52501 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12625 test cases. fast/canvas/webgl/drawArraysOutOfBounds.html -> failed Exiting early after 1 failures. 5073 tests run. 88.37s total testing time 5072 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1553245
Comment on attachment 52501 [details] Proposed patch Clearing flags on attachment: 52501 Committed r57056: <http://trac.webkit.org/changeset/57056>
All reviewed patches have been landed. Closing bug.