SheriffBot should force_build builders that are idle and have failed exactly once

[Adam Barth]

SheriffBot should force_build builders that are idle and have failed exactly once

[Adam Barth]

Created attachment 52487 [details]
Patch

[Adam Barth]

Created attachment 52488 [details]
Patch

[Adam Barth]

Please review this change carefully.  This code is tricksy.

BTW, the BuildBot interface is really hard to use correctly because we have three presentations of a builder:
1) A Builder object
2) A dictionary of status information.
3) The builder's name.

It would be valuable to have the client always deal with builder objects (and to make the status information accessible via the Builder object).

[Eric Seidel (no email)]

Comment on attachment 52488 [details]
Patch

Why the crazy caching?
 109     def provoke_flaky_builders(self, revisions_causing_failures=None):
 110         if revisions_causing_failures == None:
 111             revisions_causing_failures = self._tool.buildbot.revisions_causing_failures()

I give you {}.values()
116         failed_builder_names = \
 117             set([revisions_causing_failures[key].name()
 118                  for key in revisions_causing_failures.keys()])

the red_idle_builders code should be its own function.

Otherwise looks OK.

[Adam Barth]

Created attachment 52606 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 52606 [details]
Patch

OK.

[Adam Barth]

Committed r57125: <http://trac.webkit.org/changeset/57125>