RESOLVED FIXED 37056
LayoutTests/editing/selection/move-left-right.html is slow 
https://bugs.webkit.org/show_bug.cgi?id=37056
Summary LayoutTests/editing/selection/move-left-right.html is slow
Hajime Morrita
Reported 2010-04-02 22:14:58 PDT
It takes over 13 secs to finish on my Mac Pro. Should be take at most a few second.
Attachments
patch v0 (4.83 KB, patch)
2010-04-02 22:39 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2010-04-02 22:39:44 PDT
Created attachment 52478 [details] patch v0
Hajime Morrita
Comment 2 2010-04-02 22:43:39 PDT
Original test hide each test <div> after using it. The patch changes it to remove all <div>s at once when all tests done. This reduce running time 13sec -> 3.2sec. The expectation contains storange y values, which is due to Bug 37016, that is revealed by the change. But it is not bug of this test, nor bug of the code that the test exercises.
Shinichiro Hamaji
Comment 3 2010-04-20 19:13:17 PDT
Comment on attachment 52478 [details] patch v0 > The expectation contains storange y values, which is due to Bug 37016, > that is revealed by the change. But it is not bug of this test, nor bug of the > code that the test exercises. Is it easy to fix Bug 37016? If so, I'd suggest fixing it first. > - layoutTestController.dumpAsText(); > + if (window.layoutTestController) > + layoutTestController.dumpAsText(); I think we usually put dumpAsText on the toplevel so we can call this even when runTest isn't called. Anyway, this looks good!
Eric Seidel (no email)
Comment 4 2010-04-21 18:14:36 PDT
Attachment 52478 [details] was posted by a committer and has review+, assigning to MORITA Hajime for commit.
Hajime Morrita
Comment 5 2010-04-21 20:40:45 PDT
Committed r58048: <http://trac.webkit.org/changeset/58048>
Shinichiro Hamaji
Comment 6 2010-04-21 21:46:24 PDT
You missed my comment? :)
Hajime Morrita
Comment 7 2010-04-22 13:18:10 PDT
Committed r58113: <http://trac.webkit.org/changeset/58113>
Note You need to log in before you can comment on or make changes to this bug.