RESOLVED FIXED37055
chromium-ews should run update-webkit-chromium before building 
https://bugs.webkit.org/show_bug.cgi?id=37055
Summary chromium-ews should run update-webkit-chromium before building
Adam Barth
Reported 2010-04-02 21:21:56 PDT
This is going to be tricky to fix. When someone has a patch that updates DEPS or gyp, we need to reflect those changes before building using the chromium-ews. The problem is that this breaks the model we're using (which is updating before applying the patch). We might need some lower level hook than update-webkit-chromium so we don't actually pull new revisions from svn.webkit.org. This bug is what caused the chromium-ews to miss estade's build break (because it didn't try to build the new files he added to the gypi).
Attachments
Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2010-04-02 21:38:53 PDT
IIRC the trybots just sync again after applying the patch.
Adam Barth
Comment 2 2010-04-02 21:40:53 PDT
The EWS bots are git-based. Is there a way to git svn rebase with the change in the working copy?
Evan Martin
Comment 3 2010-04-02 22:02:38 PDT
The patch should be applied against HEAD, and applying the patch doesn't change that. You just need to update the dependencies to reflect the new DEPS and re-run gyp; all of that is svn and python scripts, even when your main checkout is git.
Adam Barth
Comment 4 2011-05-01 22:20:14 PDT
This was fixed a long time ago.
Note You need to log in before you can comment on or make changes to this bug.