Bug 37055 - chromium-ews should run update-webkit-chromium before building
Summary: chromium-ews should run update-webkit-chromium before building
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-02 21:21 PDT by Adam Barth
Modified: 2011-05-01 22:20 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-02 21:21:56 PDT 
This is going to be tricky to fix.  When someone has a patch that updates DEPS or gyp, we need to reflect those changes before building using the chromium-ews.  The problem is that this breaks the model we're using (which is updating before applying the patch).  We might need some lower level hook than update-webkit-chromium so we don't actually pull new revisions from svn.webkit.org.

This bug is what caused the chromium-ews to miss estade's build break (because it didn't try to build the new files he added to the gypi).
Comment 1 Evan Martin 2010-04-02 21:38:53 PDT 
IIRC the trybots just sync again after applying the patch.
Comment 2 Adam Barth 2010-04-02 21:40:53 PDT 
The EWS bots are git-based.  Is there a way to git svn rebase with the change in the working copy?
Comment 3 Evan Martin 2010-04-02 22:02:38 PDT 
The patch should be applied against HEAD, and applying the patch doesn't change that.  You just need to update the dependencies to reflect the new DEPS and re-run gyp; all of that is svn and python scripts, even when your main checkout is git.
Comment 4 Adam Barth 2011-05-01 22:20:14 PDT 
This was fixed a long time ago.