Bug 37052 - [V8] Extend the set of types supported by SerializedScriptValue
Summary: [V8] Extend the set of types supported by SerializedScriptValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-02 17:37 PDT by Vitaly Repeshko
Modified: 2010-04-06 06:34 PDT (History)
7 users (show)

See Also:


Attachments
patch v1 (33.64 KB, patch)
2010-04-02 17:59 PDT, Vitaly Repeshko
yurys: review+
Details | Formatted Diff | Diff
patch v1.1: rebased (33.67 KB, patch)
2010-04-05 09:47 PDT, Vitaly Repeshko
no flags Details | Formatted Diff | Diff
patch v1.2: fixed delete bug in handleError (33.65 KB, patch)
2010-04-06 06:32 PDT, Vitaly Repeshko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2010-04-02 17:37:31 PDT
[V8] Extend the set of types supported by SerializedScriptValue
Comment 1 Vitaly Repeshko 2010-04-02 17:59:28 PDT
Created attachment 52472 [details]
patch v1
Comment 2 Yury Semikhatsky 2010-04-05 06:28:21 PDT
Comment on attachment 52472 [details]
patch v1

> -            push(new ObjectState(handleCast<v8::Object>(value)));
> -            // FIXME:
> -            // - check not a wrapper
> -            // - support File, ImageData, etc.
> -        }
> -        return true;
Please file a bug for the FIXME.

> +    static StateBase* newArrayState(v8::Handle<v8::Array> array, StateBase* next)
> +    {
> +        // FIXME: use plain Array state when we can quickly check that
> +        // an array is not sparse and has only indexed properties.
> +        return new SparseArrayState(array, next);
> +    }
> +
Ditto.

> +    static StateBase* newObjectState(v8::Handle<v8::Object> object, StateBase* next)
> +    {
> +        // FIXME:
> +        // - check not a wrapper
> +        // - support File, etc.
> +        return new ObjectState(object, next);
> +    }
Ditto.
Comment 3 Yury Semikhatsky 2010-04-05 06:29:30 PDT
(In reply to comment #0)
> [V8] Extend the set of types supported by SerializedScriptValue

Can we write unit tests for serialize script values?
Comment 4 Vitaly Repeshko 2010-04-05 09:39:49 PDT
(In reply to comment #3)
> (In reply to comment #0)
> > [V8] Extend the set of types supported by SerializedScriptValue
> 
> Can we write unit tests for serialize script values?

We can, but most interesting stuff is already covered by existing layout tests. (See fast/dom/Window/window-postmessage*.)
Comment 5 Vitaly Repeshko 2010-04-05 09:47:38 PDT
Created attachment 52539 [details]
patch v1.1: rebased
Comment 6 Vitaly Repeshko 2010-04-05 10:06:47 PDT
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
Committed r57079
Comment 7 WebKit Review Bot 2010-04-05 12:13:42 PDT
http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release
Comment 8 WebKit Review Bot 2010-04-05 12:16:46 PDT
http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release
Comment 9 Eric Seidel (no email) 2010-04-05 12:18:53 PDT
bug 36798 seems to be the actual culprit.  Sheriffbot should not have warned twice.
Comment 10 WebKit Review Bot 2010-04-05 12:22:12 PDT
http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release
Comment 11 WebKit Review Bot 2010-04-05 12:25:31 PDT
http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release
Comment 12 Adam Barth 2010-04-05 12:25:44 PDT
Sorry for the repeated messages.  I'm figuring out why he's spamming.
Comment 13 Adam Barth 2010-04-05 12:29:43 PDT
The problem is vitalyr@chromium.org is not in committers.py.  Fixing.
Comment 14 Adam Barth 2010-04-05 12:33:54 PDT
Sorry, he's going to spam one more time when I bring him back online.
Comment 15 WebKit Review Bot 2010-04-05 12:47:19 PDT
http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release
Comment 16 Pavel Feldman 2010-04-06 01:14:06 PDT
Comment on attachment 52539 [details]
patch v1.1: rebased

Reverted for crashing layout test in:
fast/dom/Window/window-postmessage-clone.html = CRASH

Committing to http://svn.webkit.org/repository/webkit/trunk 
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
Committed r57133
Comment 17 Pavel Feldman 2010-04-06 01:14:37 PDT
Reopening since has been rolled out.
Comment 18 Vitaly Repeshko 2010-04-06 06:32:46 PDT
Created attachment 52625 [details]
patch v1.2: fixed delete bug in handleError
Comment 19 Vitaly Repeshko 2010-04-06 06:34:48 PDT
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
Committed r57145