Bug 37050 – Toggle spell check doesn't update markers

• Status: UNCONFIRMED
• Component: HTML Editing

[Tony Gentilcore]

To reproduce:
1. Open any page with a textarea, for instance https://bugs.webkit.org/enter_bug.cgi?product=WebKit
2. Enter misspelled text, for instance "asdf asdf"
3. Right click on the text area and turn spell checking off. Notice spell markers.
4. Right click on the text area and turn spell checking back on. Notice spell markers.

Expected:
After disabling all markers should be removed. After enabling all markers should return.

Actual:
In Safari, markers are removed after disabling, but they do not return after enabling.
In Chrome, markers are only removed after disabling and selecting the text area again. Like Safari, they do not return after enabling.

The only way to recheck appears to be to go through and click on each word to check it.

I propose that in Editor.cpp:toggleContinuousSpellChecking(), the markers should be updated after toggling. I'm interested in putting a patch together which does this and adds a LayoutTest that ensures markers are updated after toggling on and off.

This is a step towards fixing the more significant issue that markers are not updated when the language is changed in Chrome (http://crbug.com/21225). After this fix is in, I am planning to just toggle between language switches.

[Tony Chang]

(In reply to comment #0)
> I propose that in Editor.cpp:toggleContinuousSpellChecking(), the markers should be updated after toggling. I'm interested in putting a patch together which does this and adds a LayoutTest that ensures markers are updated after toggling on and off.

This sounds ok to me-- maybe you can use markAllMisspellingsInRange.  The main thing to test is how this performs on very large documents.  I'm a bit worried it might lock up the UI.