RESOLVED FIXED 37028
Update image results for SVG as CSS border image tests 
https://bugs.webkit.org/show_bug.cgi?id=37028
Summary Update image results for SVG as CSS border image tests
Simon Fraser (smfr)
Reported 2010-04-02 10:16:01 PDT
The pixel results of LayoutTests/fast/borders/svg-as-border-image-2-diffs.html show that SVG as border image is broken.
Attachments
Better tests (zip) (44.21 KB, application/octet-stream)
2010-04-28 22:58 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (80.12 KB, patch)
2010-04-29 20:33 PDT, Simon Fraser (smfr) 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-04-02 10:17:09 PDT
fast/borders/svg-as-border-image.html also broken
Simon Fraser (smfr)
Comment 2 2010-04-02 10:51:03 PDT
This was broken by http://trac.webkit.org/changeset/54865
Yael
Comment 3 2010-04-02 11:42:49 PDT
I think the expected result is wrong, and the same is for fast/images/svg-as-tiled-background.html. The expected result of fast/borders/border-image-01.html shows that the image covers the whole div, so I don;t understand why this is not the case for SVG images.
Simon Fraser (smfr)
Comment 4 2010-04-28 22:58:12 PDT
Yes, I think the expected image are wrong. I have some better tests to land.
Simon Fraser (smfr)
Comment 5 2010-04-28 22:58:46 PDT
Created attachment 54678 [details] Better tests (zip)
Nikolas Zimmermann
Comment 6 2010-04-29 00:57:15 PDT
Nice tests! If you upload a patch, I'm happy to r+ them.
Nikolas Zimmermann
Comment 7 2010-04-29 00:58:21 PDT
*** Bug 35323 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 8 2010-04-29 20:33:23 PDT
Created attachment 54777 [details] Patch
Beth Dakin
Comment 9 2010-04-29 20:57:09 PDT
Comment on attachment 54777 [details] Patch r=me!
Eric Seidel (no email)
Comment 10 2010-04-30 11:01:52 PDT
It makes no sense to me, but it seems the Gtk bot seems more likely to crash in worker tests after this change (which seems impossible to be related). We'll have to monitor and see if it's just a bot issue.
Eric Seidel (no email)
Comment 12 2010-04-30 12:08:07 PDT
The Gtk bot seems to have righted itself and stopped being mad at the world. I'll follow up with Xan to see if we've seen this before/how we can avoid false-positives like this in the future.
Eric Seidel (no email)
Comment 13 2010-05-02 19:31:07 PDT
Attachment 54777 [details] was posted by a committer and has review+, assigning to Simon Fraser for commit.
Simon Fraser (smfr)
Comment 14 2010-05-02 21:14:51 PDT
This landed in http://trac.webkit.org/changeset/58580
Note You need to log in before you can comment on or make changes to this bug.