Bug 37001 - sheriffbot rollout should verify that the svn revision is a number.
Summary: sheriffbot rollout should verify that the svn revision is a number.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 18:33 PDT by David Levin
Modified: 2010-04-01 18:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.22 KB, patch)
2010-04-01 18:37 PDT, David Levin 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-04-01 18:33:16 PDT 
sheriffbot rollout should verify that the svn revision is a number.
Comment 1 David Levin 2010-04-01 18:37:03 PDT 
Created attachment 52364 [details]
Patch
Comment 2 Adam Barth 2010-04-01 18:41:03 PDT 
Comment on attachment 52364 [details]
Patch

This is good, but I'm about to remove the IRC post of the ScriptError.  You should add it back when you land this though.

Also, we should validate that the first character of reason isn't a "-".
Comment 3 David Levin 2010-04-01 18:45:56 PDT 
Committed as http://trac.webkit.org/changeset/56960