Bug 36999 - Record the IRC nick of folks who request rollouts
Summary: Record the IRC nick of folks who request rollouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 18:08 PDT by Adam Barth
Modified: 2010-04-02 00:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.96 KB, patch)
2010-04-01 18:08 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (9.73 KB, patch)
2010-04-01 19:03 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-01 18:08:01 PDT
Record the IRC nick of folks who request rollouts
Comment 1 Adam Barth 2010-04-01 18:08:26 PDT
Created attachment 52361 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-01 18:22:50 PDT
Comment on attachment 52361 [details]
Patch

I wonder if the adding of the "nick: " to output should be handled by some common "respond"/"print" function on IRCCommand.

Otherwise looks OK.
Comment 3 Adam Barth 2010-04-01 18:25:08 PDT
Yeah, I was very close to adding that.  Next time.
Comment 4 Adam Barth 2010-04-01 19:03:07 PDT
Created attachment 52366 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-04-02 00:15:05 PDT
Comment on attachment 52366 [details]
Patch for landing

Clearing flags on attachment: 52366

Committed r56977: <http://trac.webkit.org/changeset/56977>
Comment 6 WebKit Commit Bot 2010-04-02 00:15:11 PDT
All reviewed patches have been landed.  Closing bug.